On Sun, 23 Dec 2018 at 22:00, Stefan Wahren <stefan.wahren@xxxxxxxx> wrote:
>
> We need to handle mmc_of_parse() errors during probe otherwise the
> MMC driver could start without proper initialization (e.g. power sequence).
>
> Fixes: 476bf3d62d5c ("mmc: sdhci-brcmstb: Add driver for Broadcom BRCMSTB SoCs")
> Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Hi,
> since i don't have this hardware, so it is only compile tested.
> Would be nice to get a Tested-by.
>
> Regards
> Stefan
>
>
> drivers/mmc/host/sdhci-brcmstb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index 552bddc..1cd1035 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -55,7 +55,9 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
> }
>
> sdhci_get_of_property(pdev);
> - mmc_of_parse(host->mmc);
> + res = mmc_of_parse(host->mmc);
> + if (res)
> + goto err;
>
> /*
> * Supply the existing CAPS, but clear the UHS modes. This
> --
> 2.7.4
>
