On Wed, Jan 2, 2019 at 2:04 PM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > > On 31/12/18 11:40 AM, Rafael J. Wysocki wrote: > > On Sun, Dec 30, 2018 at 7:57 PM Sinan Kaya <Okaya@xxxxxxxxxx> wrote: > >> > >> On Wed, Dec 26, 2018 at 12:41 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > >>> > >>> On Mon, Dec 24, 2018 at 12:26 AM Sinan Kaya <okaya@xxxxxxxxxx> wrote: > >>>> > >>>> Select IOSF_MBI only when PCI is set. > >>>> > >>>> Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxx> > >>>> --- > >>>> drivers/mmc/host/Kconfig | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > >>>> index e26b8145efb3..4c5f037b246d 100644 > >>>> --- a/drivers/mmc/host/Kconfig > >>>> +++ b/drivers/mmc/host/Kconfig > >>>> @@ -117,7 +117,7 @@ config MMC_RICOH_MMC > >>>> config MMC_SDHCI_ACPI > >>>> tristate "SDHCI support for ACPI enumerated SDHCI controllers" > >>>> depends on MMC_SDHCI && ACPI > >>> > >>> It should depend on PCI as well, shouldn't it? > >>> > >> > >> I don't think so. The PCI dependency is at IOSF_MBI code so code > >> should select IOSF_MBI only when x86 and pci is defined as below. > >> > >> This driver does not depend on PCI. > > > > Are you sure? > > > > Do you know any systems in which to use it without PCI? > > > > Qualcomm use it and I don't know if those systems have PCI. > AMD use it but probably also have PCI. And yes Intel systems (just BYT and > CHT IIRC) that use this driver will always have PCI. QCOM doesn't use PCI for SDHC.
