On Thu, Dec 27, 2018 at 10:01:24AM +0200, Adrian Hunter wrote: > On 20/12/18 9:49 AM, BOUGH CHEN wrote: > > i.MX6ULL has errata ERR010450, point out that due to SOC I/O > > timing limitation, for eMMC HS200 and SD/SDIO 3.0 SDR104, the > > clock rate can't exceed 150MHz. And for eMMC DDR52 and SD/SDIO > > DDR50 mode, the clock rate can't exceed 45MHz. > > > > This patch add this limit for imx6ull. > > > > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx> > > Apart from the kbuild test robot complaints (do they need to be fixed?): > > Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> Nacked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> The kbuild test robot complaints do need to be fixed first. They're confusing because GCC produces quite a lot of garbage in its error messages now. If you look at the patch, there's a hunk that has: + if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) { + if (imx_data->is_ddr) + clock = clock > 45000000 ? 45000000 : clock; + else + clock = clock > 150000000 ? 150000000 : clock; + which is missing a closing brace. This patch could not have been build tested before it was mailed to the list, and the test robot is highlighting that fact. It may also be a good idea to encourage a different approach to the above anyway: if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) { unsigned long max_clock; max_clock = imx_data->is_ddr ? 45000000 : 150000000; clock = max(clock, max_clock); } rather than open-coding the max() stuff in the driver. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up