Re: [PATCH 2/2 v2] mmc: omap_hsmmc: Delete platform data GPIO CD and WP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 24, 2018 at 01:30:51PM +0200, Linus Walleij wrote:
> The OMAP HSMMC driver has some elaborate and hairy handling for
> passing GPIO card detect and write protect lines from a boardfile
> into the driver: the machine defines a struct omap2_hsmmc_info
> that is copied into struct omap_hsmmc_platform_data by
> omap_hsmmc_pdata_init() in arch/arm/mach-omap2/hsmmc.c.
> 
> However the .gpio_cd and .gpio_wp fields are not copied from
> omap2_hsmmc_info to omap_hsmmc_platform_data by
> omap_hsmmc_pdata_init() so they remain unused. The only platform
> defining omap2_hsmmc_info also define both to -1, unused.
> 
> It turn out there are no boardfiles passing any valid GPIO
> lines into the OMAP HSMMC driver at all. And since we are not
> going to add any more OMAP2 boardfiles, we can delete this
> card detect and write protect handling altogether.

After this patch, the external MMC card is not getting detected on N900
test/dev boards (different mechanics) unless I comment out the cd-gpios
in the DTS.

It seems on N900 we had these GPIOs defined to 0 by accident in
pdata-quicks, and that somehow allowed the external slot MMC work.

Anyway, do we have any other option than maintaining a different DTS for
the test/dev boards? So far, the current DTS is intended to work on both
(e.g. we have Ethernet in there too).

A.



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux