Re: [PATCH V2 mmc-utils] One further optimization of trimming routine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 08, 2018 at 10:43:01AM +0100, Michael Heimpold wrote:
> The last change to the trimming routine made it more efficient,
> however, we can even get rid of the memmove() as we leave the
> function with strdup() anyway.
> 
> Signed-off-by: Michael Heimpold <mhei@xxxxxxxxxxx>

Yes, sure, thanks!

Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Minor nit, concerning newlines, this seems to me a tad more readable:

	...
		start++;
		len--;
	}

	start[len] = '\0';
	return strdup(start);




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux