Re: [PATCH] mmc: document 'Reliable Write' bit in uapi header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Thanks, Geert!

> > -       /* Implies direction of data.  true = write, false = read */
> > +       /*
> > +        * Implies direction of data.  true = write, false = read.
> 
> nonzero = write, zero = read?

Yes, even better. Will update.

> > +        * Bit 31 selects 'Reliable Write' for RPMB.
> 
> Perhaps having a #define for this would be nice?
> Can also be used by the driver, instead of 1 << 31, which some static
> analyzers may complain about.

Maybe. Should be an incremental patch then, I'd say.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux