Linus Walleij <linus.walleij@xxxxxxxxxx> writes: Hi Linus and Ulf, I didn't make a complete review as for the other patches, I noticed only one thing which probably comes from a lack of caffeine or overdose of lisp : > + /* Try platform data instead */ > + if (if ret == -ENOENT && gpio_is_valid(gpio_ro)) { Cheers. -- Robert