On Tue, Nov 13, 2018 at 4:05 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>
> This address does not work since long time. mailmap should point you
> to current one (krzk@xxxxxxxxxx)...
Sorry, was just looking in the kernel logs for the file... :/
> Does this patch depend on anything? What tree shall take it?
It does not depend on anything but should go into the
MMC tree as at the end of the series I delete the
legacy helper functions for global GPIOs.
> > +static struct gpiod_lookup_table at2440evb_mci_gpio_table = {
> > + .dev_id = "s3c2410-sdi",
> > + .table = {
> > + /* Card detect S3C2410_GPG(10) */
> > + GPIO_LOOKUP("GPIOG", 10, "cd", GPIO_ACTIVE_LOW),
>
> I missed few changes around this... What is the "chip_label" here?
> Name of bank?
No it is whatever .label is set to inside struct gpio_chip
> In general the bank names follow different name
> convention:
> https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/samsung/pinctrl-s3c24xx.c#L58
> https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/samsung/pinctrl-s3c24xx.c#L563
> so I think it should be "gpg".
Hm since I can't run these systems I try to parse the code in
my head. Not always successfully...
This board seems to use gpio-samsung, in arch/arm/plat-samsung/gpio.c
by the call to samsung_gpiolib_init().
If I understand that code correctly, the label is set to "GPG" (capital
letters).
I'll respin with this change, thanks!
Yours,
Linus Walleij
