Re: [PATCH 04/16] block: use atomic bitops for ->queue_flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/18 5:02 PM, Christoph Hellwig wrote:
->queue_flags is generally not set or cleared in the fast path, and also
generally set or cleared one flag at a time.  Make use of the normal
atomic bitops for it so that we don't need to take the queue_lock,
which is otherwise mostly unused in the core block layer now.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
  block/blk-core.c       | 54 ++++++----------------------------------
  block/blk-mq.c         |  2 +-
  block/blk-settings.c   | 10 +++-----
  block/blk-sysfs.c      | 28 +++++++++------------
  block/blk.h            | 56 ------------------------------------------
  include/linux/blkdev.h |  1 -
  6 files changed, 24 insertions(+), 127 deletions(-)

I wonder if we can't remove the 'blk_queue_flag_XXX' helpers and replace them with inlines ...

Otherwise:

Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux