On Mon, Nov 12, 2018 at 04:09:06PM +0000, A.s. Dong wrote: > > -----Original Message----- > > From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx] > > Sent: Monday, November 12, 2018 10:13 PM > > To: linux-mmc@xxxxxxxxxxxxxxx; Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>; Shawn Guo > > <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; > > Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>; Fabio Estevam > > <fabio.estevam@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; Bartosz > > Golaszewski <brgl@xxxxxxxx> > > Subject: [PATCH 06/10] mmc: sdhci: imx: Use the slot GPIO descriptor > > > > Simplify things by making the i.MX SDHCI driver just use slot GPIO with > > descriptors instead of passing around the global GPIO numbers that we want > > to get rid of. > > > > As it turns out, just one single board is using the platform data to pass in GPIOs > > numbers for CD and WP, so we augment this to use a machine descriptor table > > instead. > > > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx> > > Cc: Fabio Estevam <fabio.estevam@xxxxxxx> > > Cc: NXP Linux Team <linux-imx@xxxxxxx> > > Cc: Bartosz Golaszewski <brgl@xxxxxxxx> > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Reviewed-by: Dong Aisheng <aisheng.dong@xxxxxxx> > > > --- > > This very much needs to be tested on the PCM043. > > > > If it works fine, it also opens the way for switching more i.MX boardfiles to > > using machine GPIO descriptor tables. > > It's almost a 10 years old board and not sure if it's still maintained by Pengutronix. I think if someone had real intereset in that board he should first port it over to device tree, so no objections from me here. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |