On Thu, Nov 01, 2018 at 08:34:16PM +0100, Wolfram Sang wrote: > > > Patch 1/3 adds support to select quirks based on SoC + ES revision using > > soc_device_match() and converts the only existing quirk. Patch 2/3 > > Removes the old method to select quirk based on compatibility string. > > While Patch 3/3 adds a new quirk from the BSP which blacklists some > > known problematic ES versions for HS400. HS400 is not yet enabled > > upstream so blacklisting these ES versions is not a regression of > > functionality. > > This will allow us even to get rid of the TMIO_MMC_HAVE_4TAP_HS400 flag > entirely because we now use it only within the Renesas part of SDHI. We > want to do this incrementally, though, because we first want to get the > HS400 feature enabled as the first step. Thanks, this looks good to me. Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>