-----Original Message----- From: kbuild test robot [mailto:lkp@xxxxxxxxx] Sent: 2018年10月23日 19:51 To: Yinbo Zhu <yinbo.zhu@xxxxxxx> Cc: kbuild-all@xxxxxx; Yinbo Zhu <yinbo.zhu@xxxxxxx>; Y.b. Lu <yangbo.lu@xxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx; Adrian Hunter <adrian.hunter@xxxxxxxxx>; ulf.hansson@xxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; Xiaobo Xie <xiaobo.xie@xxxxxxx> Subject: Re: [PATCH v3] mmc: sdhci-of-esdhc: add hs400 mode support >Hi Yangbo, >I love your patch! Yet something to improve: >[auto build test ERROR on ulf.hansson-mmc/next] [also build test ERROR on next-20181019] [cannot apply to v4.19] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] >url: https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci% 2Flinux%2Fcommits%2FYinbo-Zhu%2Fmmc-sdhci-of-esdhc-add-hs400-mode-support%2F20181023-184341&data=02%7C01%7Cyinbo.zhu%40nxp.com%7C5eaa766f6c43418686b708d638ddde8c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636758927599690192&sdata=cJECjGytybDp5Xf4Qy%2BzDWCz9uFiqqF4zOrQ%2BCYYooc%3D&reserved=0 >base: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next >config: powerpc64-allyesconfig (attached as .config) >compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 >reproduce: > wget >https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=02%7C01%7Cyinbo.zhu%40nxp.com%7C5eaa766f6c43418686b708d638ddde8c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636758927599690192&sdata=mTgF8v%2BMjWwd3qoZXGMCjrb9SjslXJE%2FWbTJTooldzo%3D&reserved=0 -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.2.0 make.cross ARCH=powerpc64 >All errors (new ones prefixed by >>): > drivers/mmc//host/sdhci-of-esdhc.c: In function 'sdhci_esdhc_probe': >> drivers/mmc//host/sdhci-of-esdhc.c:992:20: error: 'struct mmc_host_ops' has no member named 'prepare_ddr_to_hs400' > host->mmc_host_ops.prepare_ddr_to_hs400 = esdhc_prepare_ddr_to_hs400; ^ Hi kbuild_test_robot, This patch that it can be applied to git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next For the compile error, you need to apply the patch "https://patchwork.kernel.org/patch/10645289/"; first, Best Regards, Yinbo Zhu >vim +992 drivers/mmc//host/sdhci-of-esdhc.c 968 969 static int sdhci_esdhc_probe(struct platform_device *pdev) 970 { 971 struct sdhci_host *host; 972 struct device_node *np; 973 struct sdhci_pltfm_host *pltfm_host; 974 struct sdhci_esdhc *esdhc; 975 int ret; 976 977 np = pdev->dev.of_node; 978 979 if (of_property_read_bool(np, "little-endian")) 980 host = sdhci_pltfm_init(pdev, &sdhci_esdhc_le_pdata, 981 sizeof(struct sdhci_esdhc)); 982 else 983 host = sdhci_pltfm_init(pdev, &sdhci_esdhc_be_pdata, 984 sizeof(struct sdhci_esdhc)); 985 986 if (IS_ERR(host)) 987 return PTR_ERR(host); 988 989 host->mmc_host_ops.start_signal_voltage_switch = 990 esdhc_signal_voltage_switch; 991 host->mmc_host_ops.execute_tuning = esdhc_execute_tuning; > 992 host->mmc_host_ops.prepare_ddr_to_hs400 = esdhc_prepare_ddr_to_hs400; > 993 host->tuning_delay = 1; > 994 >995 esdhc_init(pdev, host); > 996 > 997 sdhci_get_of_property(pdev); > 998 > 999 pltfm_host = sdhci_priv(host); >1000 esdhc = sdhci_pltfm_priv(pltfm_host); >1001 if (soc_device_match(soc_fixup_tuning)) >1002 esdhc->quirk_fixup_tuning = true; >1003 else >1004 esdhc->quirk_fixup_tuning = false; >1005 >1006 if (esdhc->vendor_ver == VENDOR_V_22) >1007 host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; >1008 >1009 if (esdhc->vendor_ver > VENDOR_V_22) >1010 host->quirks &= ~SDHCI_QUIRK_NO_BUSY_IRQ; >1011 >1012 if (of_device_is_compatible(np, "fsl,p5040-esdhc") || >1013 of_device_is_compatible(np, "fsl,p5020-esdhc") || >1014 of_device_is_compatible(np, "fsl,p4080-esdhc") || >1015 of_device_is_compatible(np, "fsl,p1020-esdhc") || >1016 of_device_is_compatible(np, "fsl,t1040-esdhc")) >1017 host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION; >1018 >1019 if (of_device_is_compatible(np, "fsl,ls1021a-esdhc")) >1020 host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; >1021 >1022 if (of_device_is_compatible(np, "fsl,p2020-esdhc")) { >1023 /* >1024 * Freescale messed up with P2020 as it has a non-standard >1025 * host control register >1026 */ >1027 host->quirks2 |= SDHCI_QUIRK2_BROKEN_HOST_CONTROL; >1028 } >1029 >1030 /* call to generic mmc_of_parse to support additional capabilities */ >1031 ret = mmc_of_parse(host->mmc); >1032 if (ret) >1033 goto err; >1034 >1035 mmc_of_parse_voltage(np, &host->ocr_mask); >1036 >1037 ret = sdhci_add_host(host); >1038 if (ret) >1039 goto err; >1040 >1041 return 0; >1042 err: >1043 sdhci_pltfm_free(pdev); >1044 return ret; >1045 } >1046 --- 0-DAY kernel test infrastructure Open Source Technology Center https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fpipermail%2Fkbuild-all&data=02%7C01%7Cyinbo.zhu%40nxp.com%7C5eaa766f6c43418686b708d638ddde8c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636758927599690192&sdata=Y3Ul38mFSqbrR7kMjuctQo5%2F95nsAB7uCvHO9tOMgyo%3D&reserved=0 Intel Corporation
