On Mon, Oct 15, 2018 at 7:33 AM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > > > > In further testing in uniphier-sd.c, > > I found my stupid mistakes. > > I don't have the uniphier HW but I still had a look at these patches. > You never know if there is something interesting for SDHI in there :) > > > Can you squash this series into > > 3fd784f745dd > > "mmc: uniphier-sd: add UniPhier SD/eMMC controller driver" > > if you have a chance to do rebase? > > Please don't rebase! Some sub-systems rebase, and some do not. It is up to the sub-system maintainer. I am not asking to rebase just for my two fixes. I see linux-mmc regularly rebase anyway. I'd prefer cleaner git history if Ulf just happens to do one more rebase in this cycle. > We actually develop on top of mmc/next and rebasing > creates a lot of pain because we lose the base for that work. I know what you are saying, but this is how we develop in linux-next. You need to use "git rebase --onto". -- Best Regards Masahiro Yamada
