Re: [PATCH 1/2 v2] mmc: omap_hsmmc: Kill off cover detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Linus Walleij <linus.walleij@xxxxxxxxxx> [180924 11:35]:
> Cover detection appears to be a feature protecting the SD
> card on mobile phones with a slide-cover, such as some Nokia
> phones. The idea seems to be to not allow access to the
> SD card when the cover is open.
> 
> It is only usable with platform data from board files, but
> no board file in the kernel is using it, yet it takes up
> a sizeable chunk of code in the OMAP HSMMC driver.
> 
> Since we do not add new board files for the OMAPs any target
> that need this should anyway reimplement it properly using
> the device tree, so delete this legacy code.

Nice to see it unused, sounds good to me:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>

> The driver is marked as orphan in MAINTAINERS by the way.

Well there's the drivers/mmc/host/sdhci-omap.c Kishon has
done but still lacking some features. I think Kishon should
be listed as the maintainer also for omap_hsmmc.c, Kishon
does that sound OK to you?

Regards,

Tony



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux