On Tue, Sep 11, 2018 at 03:06:26PM +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
> Fixes: 26eb2607fa28 ("mmc: renesas_sdhi: add eMMC HS400 mode support")
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> So, adding HS400 support broke the detection here. I suggest we discuss
> internally, if this kind of white listing is still needed, at all. Until
> then, this patch makes things work again on H3 and M3-W.
Ouch, sorry about letting this in.
This fix looks fine to me, notwithstanding discussion of the whitelisting
approach itself.
Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index f5fcbb5dc8cd..f027f66fe0c1 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -495,7 +495,8 @@ static const struct soc_device_attribute gen3_soc_whitelist[] = {
>
> static int renesas_sdhi_sys_dmac_probe(struct platform_device *pdev)
> {
> - if (of_device_get_match_data(&pdev->dev) == &of_rcar_gen3_compatible &&
> + if ((of_device_get_match_data(&pdev->dev) == &of_rcar_gen3_compatible ||
> + of_device_get_match_data(&pdev->dev) == &of_rcar_r8a7795_compatible) &&
> !soc_device_match(gen3_soc_whitelist))
> return -ENODEV;
>
> --
> 2.18.0
>
