Re: [PATCH 1/2] mmc: renesas_sdhi: handle 4tap hs400 mode quirk based on SoC revision

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I think this design is less messy as the quirks gets added in 
> renesas_sdhi_core.c instead of needing to keep 
> renesas_sdhi_internal_dmac.c and renesas_sdhi_sys_dmac.c in sync with 
> the quirks.
> 
> Wolfram what do you think about this design?

I wonder if we can improve it if we base it on top of Yamada-san's
latest patch series? For example, I never liked TMIO_MMC_HAVE_4TAP_HS400
which is totally Renesas SDHI specific to be in the TMIO_* namespace.
Given Yamada-san's refactoring, that code went from the generic TMIO
code to Renesas specific code.

I am sure we can remove TMIO_MMC_HAVE_4TAP_HS400 then, and wonder if we
can't add a simpler quirk handling on top of it. The latter is a gut
feeling, I haven't researched it.

Niklas, can you have a look?

[1] "[PATCH v3 0/6] mmc: tmio: refactor TMIO core a bit and add UniPhier
SD/eMMC controller support"

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux