Re: [PATCH v1] mmc: add new au6601 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Oleksij,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.17 next-20180606]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Oleksij-Rempel/mmc-add-new-au6601-driver/20180607-162542
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:332:0,
                    from include/linux/kernel.h:14,
                    from include/linux/delay.h:22,
                    from drivers/mmc/host/au6601.c:9:
   drivers/mmc/host/au6601.c: In function 'au6601_trf_block_pio':
>> drivers/mmc/host/au6601.c:728:21: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}' [-Wformat=]
     dev_dbg(host->dev, "PIO, %s block size: 0x%lx\n",
                        ^
   include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
>> drivers/mmc/host/au6601.c:728:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(host->dev, "PIO, %s block size: 0x%lx\n",
     ^~~~~~~

vim +728 drivers/mmc/host/au6601.c

   702	
   703	static void au6601_trf_block_pio(struct au6601_host *host, bool read)
   704	{
   705		size_t blksize, len;
   706		u8 *buf;
   707	
   708		if (!host->blocks)
   709			return;
   710		dev_dbg(host->dev, "%s\n", __func__);
   711	
   712		if (host->dma_on) {
   713			dev_err(host->dev, "configured DMA but got PIO request.\n");
   714			return;
   715		}
   716	
   717		if (!!(host->data->flags & MMC_DATA_READ) != read) {
   718			dev_err(host->dev, "got unexpected direction %i != %i\n",
   719				!!(host->data->flags & MMC_DATA_READ), read);
   720		}
   721	
   722		if (!sg_miter_next(&host->sg_miter))
   723			return;
   724	
   725		blksize = host->data->blksz;
   726		len = min(host->sg_miter.length, blksize);
   727	
 > 728		dev_dbg(host->dev, "PIO, %s block size: 0x%lx\n",
   729			read ? "read" : "write", blksize);
   730	
   731		host->sg_miter.consumed = len;
   732		host->blocks--;
   733	
   734		buf = host->sg_miter.addr;
   735	
   736		if (read)
   737			ioread32_rep(host->iobase + AU6601_REG_BUFFER, buf, len >> 2);
   738		else
   739			iowrite32_rep(host->iobase + AU6601_REG_BUFFER, buf, len >> 2);
   740	
   741		sg_miter_stop(&host->sg_miter);
   742	}
   743	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux