Re: [PATCH v2] mmc: sdhci-of-esdhc: modify the sd clock in soc_device_match way

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[...]

>> > [Y.b. Lu] The MMC core driver used the timing MMC_TIMING_LEGACY for
>> both MMC and SD/SDIO at card initialization.
>> > However, the timing was different between MMC and SD/SDIO at
>> initialization. MMC was at legacy speed mode (up to 26MHz) while SD/SDIO
>> was at default speed mode (up to 25MHz).
>> > Actually I think we should define MMC_TIMING_MMC_LEGACY and
>> MMC_TIMING_SD_DEFAULT for MMC and SD/SDIO initializing timing.
>> > And use the right timing at the beginning in mmc_attach_sd/sdio/mmc().
>> > Any suggestion? Adrian and Uffe :)
>>
>> I am fine with that. However, you need to make sure all host drivers can cope
>> with changing this.
>>
>> Perhaps, it's also sufficient to introduce MMC_TIMING_DEFAULT (used for SD)
>> and keep MMC_TIMING_LEGACY (for MMC).
>
> [Y.b. Lu] Great. It's safe to just introduce MMC_TIMING_DEFAULT. Thanks.

Not sure what you mean by safe. I assume you  know that changing this,
requires changes all of the place. The mmc core, mmc host drivers and
even an sdio func driver that is abusing the mmc host interface...

I guess patches will show what you have in mind. :-)

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux