On 23 May 2018 at 12:52, Yinbo Zhu <yinbo.zhu@xxxxxxx> wrote:
> Add new macros for the full speed 25MHz case
For clarity, pleas re-word this as it's not a macro, but a define.
Moreover, I don't consider this a "cleanup", which is what the commit
msg header says. Instead you are adding a new define for SD default
speed mode, please make that clear.
Also, it's not clear *why* you needs this, and that you need to
explain. This change just introduce the new define but without anybody
using it, it doesn't make sense.
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@xxxxxxx>
> ---
> Change in v2:
> Modify the macro name from FULL_SPEED_MAX_DTR to DEFAULT_SPEED_MAX_DTR
> include/linux/mmc/card.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
> index 279b390..f5be8c7 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -156,6 +156,7 @@ struct sd_switch_caps {
> #define UHS_DDR50_MAX_DTR 50000000
> #define UHS_SDR25_MAX_DTR UHS_DDR50_MAX_DTR
> #define UHS_SDR12_MAX_DTR 25000000
> +#define DEFAULT_SPEED_MAX_DTR UHS_SDR12_MAX_DTR
> unsigned int sd3_bus_mode;
> #define UHS_SDR12_BUS_SPEED 0
> #define HIGH_SPEED_BUS_SPEED 1
> --
> 1.7.1
>
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
