Re: Keep rtsx_usb_ms runtime suspended when polling for cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23 May 2018 at 10:31, Kai Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote:
> Hi Alan,
>
> I just discussed with Ritesh about commit [1].
>
> Since it was concluded to be hardware problem, is it okay to revert [1]?

I don't think so.

> The end goal is to keep the card reader runtime suspended to reduce power
> consumption.

Sounds like a call to pm_suspend_ignore_children() should be called
for the USB parent device, conditionally, when the HW works as you
suggest.

Would that work instead?

>
> I just tested the rtsx_usb_ms device at my hand, and it has no problem to
> detect the card without [1] when the card reader is runtime suspended.
> I also doesn't see any error when doing I/O to the Memory Stick.
> During the test, I also reverted [2] to make sure the rtsx_usb_sdmmc doesn't
> wake up the device.
>
> [1]
> https://github.com/torvalds/linux/commit/796aa46adf1d90eab36ae06a42e6d3f10b28a75c
> [2]
> https://github.com/torvalds/linux/commit/9250aea76bfcbf4c2a7868e5566281bf2bb7af27
>
> Kai-Heng

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux