Re: [PATCH v4 0/4] mmc: renesas_sdhi: add eMMC HS400 mode support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13 May 2018 at 10:23, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> Hi Ulf,
>
> On Wed, Apr 18, 2018 at 11:56:56AM +0200, Simon Horman wrote:
>> Hi,
>>
>> this patch-set provides SDHI driver support for eMMC HS400.
>>
>> Based on mmc-v4.17-2
>>
>> Dependencies for applying these patches:
>> * none
>>
>> Dependencies to test eMMC HS400:
>> * [PATCH] clk: renesas: rcar-gen3: Fix SD divider setting
>> * [PATCH v2] arm64: dts: salvator-common: Enable HS400 of SDHI2
>>
>> To assist testing and review this patch and the above mentioned
>> dependencies, which are necessary and sufficient to enable HS400 on H3 /
>> Salvator-X, M3-W 1.0 / Salvator-X and H3 ES2.0 Salvator-XS are available
>> at:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/hs400-v4
>>
>> Changes since v3:
>> * As a follow-up to discussion with Ulf and Wolfram I have proposed
>>   two new HS400 tuning host operations. These are provided, and explained,
>>   in "mmc: core: more fine-grained hooks for HS400 tuning".
>>
>>   The following driver patches have been updated to use these new operations.
>>
>>   And "mmc: tmio: add eMMC HS400 mode support" proposes a minor cleanup
>>   to make it a little cleaner to add the proposed new host operations to
>>   the MMC core.
>
> I am wondering if you could give me some feedback on the approach that I
> have taken here.
>

Simon, apologize for the delay.

I have had a look at the series an overall the approach seems
reasonable to me. The new callbacks makes sense!

However, allow me another day for going into the details.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux