On Thu, Apr 26, 2018 at 3:23 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Thu, Apr 26, 2018 at 03:15:20PM +0200, Linus Walleij wrote: > >> If Mark doesn't say otherwise I think it would be wise to also skip >> the indirection for random syscon regulators, and go for a >> drivers/regulators/syscon-regulator.c >> based on the LEDs approach. > >> At least it shaves off a layer of indirection and gets down >> to business. > > Well, it depends on what the hardware is - if this genuinely is for > syscon-connected GPIO enabled regulators then that'd result in a bunch > of code duplication which doesn't seem great and mean that we run into > problems the minute someone decides to use both syscon and regular GPIOs > on a single regulator. True. The registers where we use syscon LEDs are definately for LEDs only. So they are not general purpose in any way whatsoever. I hope to get some code duplication and hairiness out of the way with the GPIO descriptor cleanup if I can only get that scary patch series in shape, it should get the code a bit more friendly for GPIO regulators at least. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
