Re: [PATCH v3 1/2] Documentation: mmc: add optional cd-delay-ms property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ulf,

On 2018/4/23 17:04, Ulf Hansson wrote:
On 20 April 2018 at 08:59, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
slot-gpio uses a fixed delay, 200ms, before detecting card after the card
is inserted. 200ms doesn't work for some platforms, so some host drivers
added their own properties for parsing that from DT, for instance,
dw_mmc and pxamci. That being said, it should also be tunable when using
cd-gpios.

Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

---

Changes in v3:
- fix misleading typo in commit msg

Changes in v2: None

  Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
index 467cd7b..215b9a2 100644
--- a/Documentation/devicetree/bindings/mmc/mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/mmc.txt
@@ -19,6 +19,8 @@ Optional properties:
  - wp-gpios: Specify GPIOs for write protection, see gpio binding
  - cd-inverted: when present, polarity on the CD line is inverted. See the note
    below for the case, when a GPIO is used for the CD line
+- cd-delay-ms: Set delay time before detecting card after card insert interrupt.
+  It's only valid when cd-gpios is present.

I would prefer the property to be named "cd-debounce-delay-ms"
instead. Would you mind changing it?


ok, will change it in v4.

  - wp-inverted: when present, polarity on the WP line is inverted. See the note
    below for the case, when a GPIO is used for the WP line
  - disable-wp: When set no physical WP line is present. This property should
--
1.9.1



Kind regards
Uffe




--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux