Re: [RFC PATCH] Revert "mmc: increase power up delay"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> > The intention for this revert is that the it's too engineering
> > solution for a special board but force all platforms to wait
> > for that long time, especially painful for mmc_power_up for eMMC
> > when booting.

Careful! It was *introduced* for one specific board. But we can't tell
if other platforms benefit from this since 2009(!).

> > In practise, the modern hardware should have a stable power supply

While I agree, sill notice the "should". Reality is often enough
different.

> > It has been long time proved 2ms is enough when testing variety of

Where is that proof? If we have such a proof, things would be easy, but
I really have strong doubts. We have indications, at best, I'd say.

> This is true if there is an external regulator, but sometimes we use
> host specific ways to power the card.

This is also true and to be considered.

> >
> > Just revert it now and see if it could smokes out something interesting.

Hell, no! "Let's change it to my needs and if it breaks for other
people, they can complain"? That's not how Linux development works, we
should try as hard as possible to not introduce regressions.

> An option is to use an opt-out method, perhaps via a new host cap?

Opt-in for the shortened delay, I'd suggest. Platforms which know they
need less delay can set it. White listing.

NAK for the original patch.

Regards,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux