Re: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: fall back to PIO if scatterlist doesn't match

[Wolfram Sang <wsa@xxxxxxxxxxxxx>]

> > -       /* This DMAC cannot handle if sg_len is not 1 */
> > -       WARN_ON(host->sg_len > 1);
> > -
> > -       /* This DMAC cannot handle if buffer is not 8-bytes alignment */
> > -       if (!IS_ALIGNED(sg->offset, 8))
> > +       if (WARN_ON(host->sg_len > 1) || !IS_ALIGNED(sg->offset, 8))
> 
> The WARN_ON becomes a bit misleading being a part of the if statement,
> as it should never happen when the driver has set ->max_segs = 1.

Uh, yeah, right. So, we could simply drop the WARN_ON?

Attachment: signature.asc
Description: PGP signature