Hi Shawn, On 04/03/2018 02:46 PM, Shawn Lin wrote: > Hi Harish, > > On 2018/4/3 19:34, Harish Jenny K N wrote: >> This patch adds a quirk to handle broken UHS which >> can be used to reduce the SDIO clock rate for some >> chips with broken UHS. >> > > Well, it's Ulf's call if it looks good to him, but I still don't like > this patch, which adds freq limit for a specific wifi, especially in > core driver, sorry. Another one could say "Hey, I have a buggy wifi > that should only use 120MHz". So how would you name the quirk for that? > definitely it could happen in the future, and hopefully a change to generalize max frequencies supported by broken cards won't be overly complicated, but firstly let's wait for reports about other such cards. > Wifi is probably soldered on board, so why can't you limit the > max-frequency = <150000000> there? > Like you said it might be a working solution for a particular board with a hardwired Marvell card, but what if a card module is placed to a slot? The addressed problem is related to the specific card, and apparently it is incorrect to workaroud it by adjusting a host controller property to comply with a specific card, also your workaroud is for OF platforms only. >From my point of view a new card quirk is the proper way to deal with the issue. -- With best wishes, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
