Re: Regression in commit "mmc: sdhci-acpi: Handle return value of platform_get_irq"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[...]

>> I'm guessing that the above means the eMMC does have an interrupt,
>> IRQ0?
>
> Yes.
>
> Ulf, here is the fix:
>
> From: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Date: Wed, 21 Mar 2018 11:34:44 +0200
> Subject: [PATCH] mmc: sdhci-acpi: Fix IRQ 0
>
> Zero is a valid IRQ number and is being used on some CHT tablets. Stop
> treating it as an error.
>
> Reported-by: Luke Ross <luke@xxxxxxxxxxxxx>
> Fixes: 1b7ba57ecc86 ("mmc: sdhci-acpi: Handle return value of platform_get_irq")
> Cc: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Thanks, applied for fixes!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 4065da58789d..32321bd596d8 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -680,7 +680,7 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
>         host->hw_name   = "ACPI";
>         host->ops       = &sdhci_acpi_ops_dflt;
>         host->irq       = platform_get_irq(pdev, 0);
> -       if (host->irq <= 0) {
> +       if (host->irq < 0) {
>                 err = -EINVAL;
>                 goto err_free;
>         }
> --
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux