> -----Original Message----- > From: Andy Shevchenko [mailto:andriy.shevchenko@xxxxxxxxxxxxxxx] > Sent: Monday, March 12, 2018 12:08 PM > To: Harish Jenny K N <harish_kandiga@xxxxxxxxxx>; ulf.hansson@xxxxxxxxxx; > linus.walleij@xxxxxxxxxx; adrian.hunter@xxxxxxxxx; shawn.lin@rock- > chips.com; Avri Altman <Avri.Altman@xxxxxxx> > Cc: linux-mmc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > Vladimir_Zapolskiy@xxxxxxxxxx > Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs. > > On Mon, 2018-03-12 at 10:01 +0530, Harish Jenny K N wrote: > > This patch exports the host capabilities to debugfs > > > > This idea of sharing host capabilities over debugfs came up from Abbas > > Raza <Abbas_Raza@xxxxxxxxxx> Earlier discussions: > > https://lkml.org/lkml/2018/3/5/357 > > https://www.spinics.net/lists/linux-mmc/msg48219.html > > > > Address below minors and, FWIW, take mine > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > + for_each_set_bit(bit, (const unsigned long *)&caps, > > BITS_PER_LONG) > > > + for_each_set_bit(bit, (const unsigned long *)&caps2, > > BITS_PER_LONG) > > Explicit casting is not needed anymore in both cases. Also maybe use sizeof(mmc_host_capabilities) instead of BITS_PER_LONG? > > -- > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Intel Finland Oy ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
