Re: [PATCH 00/14] Enable SD/MMC on JZ4780 SoCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mathieu,

On 10 March 2018 at 14:02, Mathieu Malaterre <malat@xxxxxxxxxx> wrote:
> On Fri, Mar 9, 2018 at 4:12 PM, Ezequiel Garcia
> <ezequiel@xxxxxxxxxxxxxxxxxxxx> wrote:
>> This patchset adds support for SD/MMC on JZ4780 based
>> platforms, such as the MIPS Creator CI20 board.
>>
>> Most of the work has been done by Alex, Paul and Zubair,
>> while I've only prepared the upstream submission, cleaned
>> some patches, and written some commit logs where needed.
>>
>> All praises should go to them, all rants to me.
>>
>> The series is based on v4.16-rc4.
>>
>> Alex Smith (3):
>>   mmc: jz4740: Set clock rate to mmc->f_max rather than JZ_MMC_CLK_RATE
>>   mmc: jz4740: Add support for the JZ4780
>>   mmc: jz4740: Fix race condition in IRQ mask update
>>
>> Ezequiel Garcia (9):
>>   mmc: jz4780: Order headers alphabetically
>>   mmc: jz4740: Use dev_get_platdata
>>   mmc: jz4740: Introduce devicetree probe
>>   mmc: dt-bindings: add MMC support to JZ4740 SoC
>>   mmc: jz4740: Use dma_request_chan()
>>   MIPS: dts: jz4780: Add DMA controller node to the devicetree
>>   MIPS: dts: jz4780: Add MMC controller node to the devicetree
>>   MIPS: dts: ci20: Enable DMA and MMC in the devicetree
>>   MIPS: configs: ci20: Enable DMA and MMC support
>>
>> Paul Cercueil (1):
>>   mmc: jz4740: Fix error exit path in driver's probe
>>
>> Zubair Lutfullah Kakakhel (1):
>>   mmc: jz4740: Reset the device requesting the interrupt
>
> Nice work. Entire series works just fine on my MIPS Creator CI20 (v1).
>

Cool. This means a Tested-by for the entire series?

> Nitpick: could you update the email addresses:
>
> s/imgtec/mips/
>

You sure that is appropriate? First of all, the work has done
under Imagination Technologies umbrella (even if now the
developers work for MIPS).

And second, I'd feel better if such request would come
from the authors, or at least acked by them.

Thanks for testing!
-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux