Re: [PATCH v1] mmc: core: Re-use DEFINE_SHOW_ATTRIBUTE() macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14 February 2018 at 16:45, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> ...instead of open coding file operations followed by custom ->open()
> callbacks per each attribute.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/core/debugfs.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> index 0f4a7d7b2626..c51e0c044a3e 100644
> --- a/drivers/mmc/core/debugfs.c
> +++ b/drivers/mmc/core/debugfs.c
> @@ -196,18 +196,7 @@ static int mmc_ios_show(struct seq_file *s, void *data)
>
>         return 0;
>  }
> -
> -static int mmc_ios_open(struct inode *inode, struct file *file)
> -{
> -       return single_open(file, mmc_ios_show, inode->i_private);
> -}
> -
> -static const struct file_operations mmc_ios_fops = {
> -       .open           = mmc_ios_open,
> -       .read           = seq_read,
> -       .llseek         = seq_lseek,
> -       .release        = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(mmc_ios);
>
>  static int mmc_clock_opt_get(void *data, u64 *val)
>  {
> --
> 2.15.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux