On 02/24/2018 01:16 AM, Andy Shevchenko wrote: > On Fri, Feb 23, 2018 at 4:19 PM, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote: >> On 2018/2/23 21:27, Andy Shevchenko wrote: >>> On Fri, Feb 23, 2018 at 8:41 AM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> >>> wrote: >>>> >>>> 'clock-freq-min-max' property had already deprecated. >>>> Remove the 'clock-freq-min-max' property that is kept to maintain >>>> the compatibility. >>> >>> >>> Removing a property without telling the user what to expect is a bad >>> idea and ABI breakage. >>> >> >> What's the general process to remove a property? >> >> I guess we should do: >> 1) deprecate it in the first place and remove it from all upstream DT >> 2) wait some long enough days for expecting the stale of all old DTB >> containing that property >> 3) remove the functionality of the deprecated property from the driver >> but still leave some warning there >> 4) remove the left warning finally > > I don't know. Perhaps Rob can shed a light here. > But I would really OK with removal of some of such properties from > some drivers where it's more burden to keep them. This property had deprecated about 8months ago. I think that it was enough to keep this property for maintaining the compatibility. I didn't remove this property without any alternative. Best Regards, Jaehoon Chung > >> And for the ABI breakage, we should add something in Documentation/ABI >> /obsolete or Documentation/ABI/removed ? > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html