Re: [PATCH] mmc: dw_mmc: Remove prev_state and state assignment for STATE_SENDING_CMD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/23/2018 11:23 AM, Shawn Lin wrote:
> Clang reports a compile warning:
> drivers/mmc/host/dw_mmc.c:2124:5: warning: Value stored to 'prev_state'
> is never read
> 
> By checking the code, prev_state and state assignment for
> STATE_SENDING_CMD is indeed never used after jumping to unlock tag.
> So remove it.
> 
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

Will apply yours. Thanks!

Best Regards,
Jaehoon Chung

> ---
> 
>  drivers/mmc/host/dw_mmc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 0aa3997..5d5d026 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2021,7 +2021,6 @@ static void dw_mci_tasklet_func(unsigned long priv)
>  			set_bit(EVENT_CMD_COMPLETE, &host->completed_events);
>  			err = dw_mci_command_complete(host, cmd);
>  			if (cmd == mrq->sbc && !err) {
> -				prev_state = state = STATE_SENDING_CMD;
>  				__dw_mci_start_request(host, host->slot,
>  						       mrq->cmd);
>  				goto unlock;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux