Hi Ulf, > -----Original Message----- > From: Ulf Hansson [mailto:ulf.hansson@xxxxxxxxxx] > Sent: 2017年12月19日 16:36 > To: Xinming Hu <huxm@xxxxxxxxxxx> > Cc: Linux MMC <linux-mmc@xxxxxxxxxxxxxxx>; Zhiyuan Yang > <yangzy@xxxxxxxxxxx>; Tim Song <songtao@xxxxxxxxxxx>; Cathy Luo > <cluo@xxxxxxxxxxx>; James Cao <jcao@xxxxxxxxxxx>; Ganapathi Bhat > <gbhat@xxxxxxxxxxx>; Amitkumar Karwar <akarwar@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH v5 1/2] mmc: API for accessing host supported > maximum segment count and size > > External Email > > ---------------------------------------------------------------------- > On 22 November 2017 at 08:49, Xinming Hu <huxm@xxxxxxxxxxx> wrote: > > sdio device drivers need be able to get the host supported max_segs > > and max_seg_size, so that they know the buffer size to allocate while > > utilizing the scatter/gather DMA buffer list. > > > > This patch provides API for this purpose. > > Apologize for the delay. > > Overall, this makes perfect sense to me. However some minor comment, see > below. > Ok, great news ! > > > > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > --- > > v2: v2 was submitted with minor improvement like replacing BUG_ON() > > with WARN_ON() > > v3: Addressed below review comments from Ulf Hansson > > a) In v3, patch has been split into two separate patches. > > b) Patch 1/2 introduces an API to fetch max_seg_size and max_segs > > c) Replaced WARN_ON() with proper error code when sg_ptr->length is > invalid > > d) Instead of duplicating the code in mmc_io_rw_extended(), extra bool > parameter > > has been added to this function and used it in new APIs for SG. > > v4: Removed WARN_ON() calls in newly added APIs. It's gets called in probe > handler. > > Caller already takes care of it(Shawn Lin). > > v5: Rebased on latest code base. > > --- > > drivers/mmc/core/sdio_io.c | 21 > +++++++++++++++++++++ > > .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 6 +++--- > > The changes to the wifi driver, could please make that a separate patch on top > of this one? > > There are actually a couple of more wireless drivers that should convert to use > these new API, I would appreciate if you could fold in patches in the series for > each of them as well (don't forget to cc correct people for them), then I intend > to apply all of them via my tree, if no objections. Okay, I will include the changes in v6. > > Otherwise this change looks good to me! > Thanks for the review! Regards, Simon > [...] > > Kind regards > Uffe ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
