Hi Ulf, Could you please let us know if you have any further review comments on this patch series. Regards, Simon > -----Original Message----- > From: Amitkumar Karwar > Sent: 2016年8月9日 18:16 > To: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > Cc: Nishant Sarmukadam <nishants@xxxxxxxxxxx>; Wei-Ning Huang > <wnhuang@xxxxxxxxxxxx>; linux-mmc@xxxxxxxxxxxxxxx; Cathy Luo > <cluo@xxxxxxxxxxx>; Xinming Hu <huxm@xxxxxxxxxxx> > Subject: RE: [PATCH v4 1/2] mmc: API for accessing host supported maximum > segment count and size > > Hi Ulf, > > > From: Amitkumar Karwar [mailto:akarwar@xxxxxxxxxxx] > > Sent: Thursday, June 16, 2016 2:53 PM > > To: linux-wireless@xxxxxxxxxxxxxxx > > Cc: Nishant Sarmukadam; Wei-Ning Huang; linux-mmc@xxxxxxxxxxxxxxx; > > Cathy Luo; Xinming Hu; Amitkumar Karwar > > Subject: [PATCH v4 1/2] mmc: API for accessing host supported maximum > > segment count and size > > > > From: Xinming Hu <huxm@xxxxxxxxxxx> > > > > sdio device drivers need be able to get the host supported max_segs > > and max_seg_size, so that they know the buffer size to allocate while > > utilizing the scatter/gather DMA buffer list. > > > > This patch provides API for this purpose. > > > > Signed-off-by: Xinming Hu <huxm@xxxxxxxxxxx> > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > --- > > v2: v2 was submitted with minor improvement like replacing BUG_ON() > > with > > WARN_ON() > > v3: Addressed below review comments from Ulf Hansson > > a) In v3, patch has been split into two separate patches. > > b) Patch 1/2 introduces an API to fetch max_seg_size and max_segs > > c) Replaced WARN_ON() with proper error code when sg_ptr->length > > is invalid > > d) Instead of duplicating the code in mmc_io_rw_extended(), extra > > bool parameter > > has been added to this function and used it in new APIs for SG. > > v4: Removed WARN_ON() calls in newly added APIs. It's gets called in > > probe handler. > > Caller already takes care of it(Shawn Lin). > > --- > > drivers/mmc/core/sdio_io.c | 21 > > +++++++++++++++++++++ > > .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 6 +++--- > > include/linux/mmc/sdio_func.h | 3 +++ > > 3 files changed, 27 insertions(+), 3 deletions(-) > > > > Please let me know if you have any further review comments for this patch > series. > > Regards, > Amitkumar ?韬{.n?????%??檩??w?{.n???{炳i?)?骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
