On 14 November 2017 at 03:48, Huijin Park <huijin.park@xxxxxxxxxxx> wrote: > Some eMMC products keep busy time a little longer intermittently. > (eg. prepare free blocks, garbage collection...) > In this case, we recommend to wait a little longer than fail. Is this an rpmb specific problem, because the code seems only to change that. Is it write and read or only write? > > Signed-off-by: Huijin Park <huijin.park@xxxxxxxxxxx> > --- > drivers/mmc/core/block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c > index ea80ff4..b5b0fe6 100644 > --- a/drivers/mmc/core/block.c > +++ b/drivers/mmc/core/block.c > @@ -584,7 +584,7 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct mmc_blk_data *md, > * Ensure RPMB command has completed by polling CMD13 > * "Send Status". > */ > - err = ioctl_rpmb_card_status_poll(card, &status, 5); > + err = ioctl_rpmb_card_status_poll(card, &status, 50); First, you are changing "re-tries" not a timeout value, which would seem like a better approach. Second, it seems like we should remove the ioctl_rpmb_card_status_poll() function altogether and instead make use of the more generic card_busy_detect() function here. Then if card_busy_detect() needs to be adopted to suite rpmb, then we should do that instead. > if (err) > dev_err(mmc_dev(card->host), > "%s: Card Status=0x%08X, error %d\n", > -- > 1.9.1 > Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
