Hi Jan,
On 2017/10/26 19:03, Jan Glauber wrote:
On Thu, Oct 26, 2017 at 12:46:02PM +0200, Ulf Hansson wrote:
On 26 October 2017 at 03:19, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
Hi, Ulf
On 2017/9/27 11:40, Shawn Lin wrote:
Per SD specification version 4.10, section 4.3.4, it says "pre-erased
(ACMD23) will make a following Multiple Block Write operation faster
compared to the same operation without preceding ACMD23". ACMD23 is
mandatory for all sd cards and the spec also says "Command STOP_TRAN
(CMD12) shall be used to stop the transmission in Write Multiple Block
whether or not the preerase (ACMD23) feature is used."
Ping... :)
Hi Shawn,
Actually I was waiting for confirmation from Jan about his tests.
The patches worked for me but I'm not sure I've actually tested ACMD23.
Do I need to trigger ACMD23 somehow?
Thanks for testing!
You need a card which doesn't support CMD23 and try to write something
to the card to see if it works well. But given that it's not
easy to identify whether a card support CMD23, I suggest to hack the
code for force all SD cards to use ACMD23.
Could you kindly try this on top of this series? And do some write test
for the SD cards.
@@ -2210,9 +2210,9 @@ static struct mmc_blk_data
*mmc_blk_alloc_req(struct mmc_card *card,
if (mmc_host_cmd23(card->host)) {
if ((mmc_card_mmc(card) &&
- card->csd.mmca_vsn >= CSD_SPEC_VER_3) ||
- (mmc_card_sd(card) &&
- card->scr.cmds & SD_SCR_CMD23_SUPPORT))
+ card->csd.mmca_vsn >= CSD_SPEC_VER_3))
+ //(mmc_card_sd(card) &&
+ //card->scr.cmds & SD_SCR_CMD23_SUPPORT))
md->flags |= MMC_BLK_CMD23;
Thanks.
--Jan
However, overall the series looks reasonable to me.
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
