Re: [PATCH] mmc: dw_mmc: Increase the timeout in mci_send_cmd to 5 sec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2017/10/2 21:29, Bernd Edlinger wrote:
On 10/02/17 09:13, Ulf Hansson wrote:
On 30 September 2017 at 17:38, Bernd Edlinger <bernd.edlinger@xxxxxxxxxx> wrote:

Signed-off-by: Bernd Edlinger <bernd.edlinger@xxxxxxxxxx>

Why?


Obviously the 0.5 seconds time-out was not sufficent for me.
I experienced a time-out I believe it was with an erase command,
that took around one second to complete.  Not all brands of SD
card behave this way, but some do.

The timeout in mci_send_cmd is suffcient. Ideally SDMMC_CMD_START
should be cleared immediately once the cmd was sent out. The only
reason that it wasn't, is that at least one of the IO, including
cmd line and all data lines used, is kept low for whatever reason.

Per your description, the failed case suffers from a long busy time
due to the previous erase command(R1b). But I think the following
command which was expected to use data line, shouldn't be fired to
the host drivers at all without checking the busy state. Otherwise....



Incidentally I had a similar problem with a completely different
hardware, see: https://bugzilla.kernel.org/show_bug.cgi?id=107811
Should I send a patch for that as well?

are there more cases to be fixed?



Bernd.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux