On 10 October 2017 at 09:35, Chaotian Jing <chaotian.jing@xxxxxxxxxxxx> wrote: > On Tue, 2017-10-10 at 09:26 +0200, Ulf Hansson wrote: >> [...] >> >> > + >> > +static const struct of_device_id msdc_of_ids[] = { >> > + { .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat}, >> > + { .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat}, >> > + { .compatible = "mediatek,mt2701-mmc", .data = &mt2701_compat}, >> > + { .compatible = "mediatek,mt2712-mmc", .data = &mt2712_compat}, >> > + {} >> > +}; >> > +MODULE_DEVICE_TABLE(of, msdc_of_ids); >> >> As already stated in the other reply. These new compatible changes >> needs to be discussed and acked before the driver starts using them. >> >> In other words, make patch3 to precede this one. > but, then there will have a probe issue as mentioned in previous mail > list. that's why I separate the binding file changes to 2 patches. That sounds seriously wrong. Aren't the bindings backwards compatible? Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html