Dear Shawn, Thank you for your help, I'm new here :-) I hope the title is n ow ok. Of course selection would also be ok. I thought about both solutions and I was not sure what you prefer. I choose the depends on solution, because of the Kconfig language specification recommends not to select of visible config options (see reverse dependencies in https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt), because the selection will ignore any depends on constraints. However, I already now some similar examples of selected visible variables. Thus, I think it would also be ok to select the PCI_QUIRKS in this situation. Shall I create a new patch? Best regards, Sascha El-Sharkawy -- ----------------------------------------------------------------------- Sascha El-Sharkawy, MSc University of Hildesheim Tel.: +49 (0) 5121 / 883-40336 Institute of Computer Science Fax: +49 (0) 5121 / 883-40337 Universitätsplatz 1 elscha@xxxxxxxxxxxxxxxxxxxxx D-31141 Hildesheim, Germany http://www.sse.uni-hildesheim.de > -----Ursprüngliche Nachricht----- > Von: Shawn Lin [mailto:shawn.lin@xxxxxxxxxxxxxx] > Gesendet: Freitag, 22. September 2017 15:29 > An: Sascha El-Sharkawy; ulf.hansson@xxxxxxxxxx > Cc: shawn.lin@xxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx > Betreff: Re: [Patch] MULTIMEDIA CARD (MMC): Avoid useless selection of > MMC_RICOH_MMC quirk > > On 2017/9/22 20:21, Sascha El-Sharkawy wrote: > > Ensure correct functionality of MMC_RICOH_MMC pci quirk. > > > > MMC_RICOH_MMC is a pci quirk (realized in /drivers/pci/quirks.c lines > > 2877 > > - 2959), which in turn depend on PCI_QUIRKS. However, > MMC_RICOH_MMC > > can be selected even if pci quirks (PCI_QUIRKS) are globally disabled. > > This patch adds the missing dependency to MMC_RICOH_MMC to ensure > that > > it can only be selected if pci quirks are active. > > > > The commit title should be something like: > mmc: ricoh: Avoid ........ > > > Signed-off-by: Sascha El-Sharkawy <elscha@xxxxxxxxxxxxxxxxxxxxx> > > --- > > drivers/mmc/host/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index > > 8c15637..81143fb 100644 > > --- a/drivers/mmc/host/Kconfig > > +++ b/drivers/mmc/host/Kconfig > > @@ -91,7 +91,7 @@ config MMC_SDHCI_PCI > > > > config MMC_RICOH_MMC > > bool "Ricoh MMC Controller Disabler" > > - depends on MMC_SDHCI_PCI > > + depends on MMC_SDHCI_PCI && PCI_QUIRKS > > So why not select PCI_QUIRKS directly here? > > > default y > > help > > This adds a pci quirk to disable Ricoh MMC Controller. This > > N r y b X ǧv ^ ){.n + { g" ^n r z h & G h > > ( 階 ݢj" m z ޖ f h ~ mml== > > > > > -- > Best Regards > Shawn Lin ��.n��������+%������w��{.n�����{��i��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
