Re: [Patch] MULTIMEDIA CARD (MMC): Avoid useless selection of MMC_RICOH_MMC quirk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017/9/22 20:21, Sascha El-Sharkawy wrote:
Ensure correct functionality of MMC_RICOH_MMC pci quirk.

MMC_RICOH_MMC is a pci quirk (realized in /drivers/pci/quirks.c lines 2877
- 2959), which in turn depend on PCI_QUIRKS. However, MMC_RICOH_MMC can be
selected even if pci quirks (PCI_QUIRKS) are globally disabled. This patch
adds the missing dependency to MMC_RICOH_MMC to ensure that it can only be
selected if pci quirks are active.


The commit title should be something like:
mmc: ricoh: Avoid ........

Signed-off-by:  Sascha El-Sharkawy <elscha@xxxxxxxxxxxxxxxxxxxxx>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 8c15637..81143fb 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -91,7 +91,7 @@ config MMC_SDHCI_PCI

 config MMC_RICOH_MMC
 	bool "Ricoh MMC Controller Disabler"
-	depends on MMC_SDHCI_PCI
+	depends on MMC_SDHCI_PCI && PCI_QUIRKS

So why not select PCI_QUIRKS directly here?

 	default y
 	help
 	  This adds a pci quirk to disable Ricoh MMC Controller. This
N�����r��y���b�X��ǧv�^�)޺{.n�+����{��g"��^n�r���z���h����&���G���h�(�階�ݢj"���m�����z�ޖ���f���h���~�mml==



--
Best Regards
Shawn Lin

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux