Hi On 2017/9/22 16:42, Ulf Hansson wrote:
On 10 September 2017 at 01:44, Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx> wrote:To get an ATP card work reliable on a high speed bus, CMD23 needs to be disabled. Without this patch: $ dd if=/dev/urandom of=/mnt/test bs=1M count=10 <mmc0: starting CMD23 arg 00000400 flags 00000015> mmc0: starting CMD25 arg 00a71f00 flags 000000b5 mmc0: blksz 512 blocks 1024 flags 00000100 tsac 3000 ms nsac 0 mmc0: CMD12 arg 00000000 flags 0000049d sdhci [sdhci_irq()]: *** mmc0 got interrupt: 0x00000001 mmc0: Timeout waiting for hardware interrupt.Seems like you are using some sdhci variant. Would it be possible for you to test this card on another platform? That to make sure it's not a driver thing.
I'm just curious about if these ATP cards could work for ACMD23? Could you kindly try this patch? |https://patchwork.kernel.org/patch/9887651/
Signed-off-by: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx> --- Changes since v1: - s/CMD32/CMD23 drivers/mmc/core/card.h | 1 + drivers/mmc/core/quirks.h | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h index f06cd91..af9c48c 100644 --- a/drivers/mmc/core/card.h +++ b/drivers/mmc/core/card.h @@ -75,6 +75,7 @@ struct mmc_fixup { #define EXT_CSD_REV_ANY (-1u) #define CID_MANFID_SANDISK 0x2 +#define CID_MANFID_ATP 0x9 #define CID_MANFID_TOSHIBA 0x11 #define CID_MANFID_MICRON 0x13 #define CID_MANFID_SAMSUNG 0x15 diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index fb72593..3205f0e 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -52,6 +52,12 @@ static const struct mmc_fixup mmc_blk_fixups[] = { MMC_QUIRK_BLK_NO_CMD23), /* + * Some SD cards lockup while using CMD23 multiblock transfers. + */ + MMC_FIXUP("AF SD", CID_MANFID_ATP, CID_OEMID_ANY, add_quirk_sd, + MMC_QUIRK_BLK_NO_CMD23),Is really all ATP cards having this problem? Perhaps we should consider making this a bit more fine grained? On the other hand, this may be the safest way to do it...+ + /* * Some MMC cards need longer data read timeout than indicated in CSD. */ MMC_FIXUP(CID_NAME_ANY, CID_MANFID_MICRON, 0x200, add_quirk_mmc, -- 2.1.4Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
