Re: [PATCH] mmc: block: cast a error log for unbalanced mmc_blk_{open, release}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[...]

>
>>> +               if (mmc_card_is_removable(card->host) && devidx ==
>>> -ENOSPC)
>>
>>
>> Why not print this error for all type of cards, it seems like relevant
>> information for the user.
>
>
> Only if we support booting rootfs from other media and that could
> allow modular mmc-blk for non-removable devices. But then static
> mmc_blk_ida would be freed anyway. So it won't face this situation?

Well, I wasn't thinking about the behavior of userspace. Instead, the
information would be printed if the device had more partitions than
what we support...

>
>>
>>> +                       dev_err(mmc_dev(card->host),
>>> +                               "possible unblanced mount/umount
>>> detected\n");

..perhaps then also change this to "no more device IDs available".

>>> +
>>>                  return ERR_PTR(devidx);
>>> +       }
>>>
>>>          md = kzalloc(sizeof(struct mmc_blk_data), GFP_KERNEL);
>>>          if (!md) {
>>> --

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux