On Thu, Aug 10, 2017 at 2:08 PM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > mmc_return_hold() / mmc_retune_release() are used around a group of > commands to prevent re-tuning between the commands. Re-tuning can still > happen before the first command. In some cases, re-tuning must be > prevented entirely. Add mmc_retune_hold_now() for that purpose. It is > added in preparation for CQE support where it will be used by CQE recovery. > > Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > +void mmc_retune_hold_now(struct mmc_host *host) > void mmc_retune_release(struct mmc_host *host) If the only hint we have about how to use these functions is through the commit log we are in trouble, but I would say in this case the function name is kind of half-obvious at least. I think what troubles me is Rusty's API maturity guideline #6 "6. The name tells you how to use it." Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html