On 14/08/17 18:28, Masahiro Yamada wrote: > Hi Adrian, > > > 2017-08-14 19:53 GMT+09:00 Adrian Hunter <adrian.hunter@xxxxxxxxx>: > >>> @@ -353,6 +390,28 @@ static int sdhci_cdns_probe(struct platform_device *pdev) >>> return ret; >>> } >>> >>> +static int __maybe_unused sdhci_cdns_resume(struct device *dev) >> >> We don't use __maybe_unused in this case, we use #ifdef CONFIG_PM_SLEEP > > > Could you tell me the reason > why #ifdef CONFIG_PM_SLEEP is preferable? > > I see lots of __maybe_unused for suspend/resume hooks in drivers. Not in sdhci drivers. It is easier for the maintainer to have consistency across the code they maintain. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
