Hi Ulf, 2017-08-03 19:51 GMT+09:00 Ulf Hansson <ulf.hansson@xxxxxxxxxx>: > On 31 July 2017 at 13:59, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote: >> This fixes the following sparse warnings: >> >> CHECK drivers/mmc/host/mmci_qcom_dml.c >> drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static? >> drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static? >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > > Thanks, applied for next! > > Kind regards > Uffe > >> --- >> >> drivers/mmc/host/mmci_qcom_dml.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c >> index 00750c9d3514..95de699853d2 100644 >> --- a/drivers/mmc/host/mmci_qcom_dml.c >> +++ b/drivers/mmc/host/mmci_qcom_dml.c >> @@ -18,6 +18,7 @@ >> #include <linux/mmc/host.h> >> #include <linux/mmc/card.h> >> #include "mmci.h" >> +#include "mmci_qcom_dml.h" >> >> /* Registers */ >> #define DML_CONFIG 0x00 Please drop this. Kbuild test robot reported a build error and it revealed another problem for this driver. (#ifdef CONFIG_MMC_QCOM_DML must be #if IS_ENABLED(CONFIG_MMC_QCOM_DML) because this driver is tristate) I will send v2 soon. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
