On 18/07/17 12:01, Shawn Lin wrote:
> sdhci uses CONFIG_MMC_DEBUG for showing ADMA descriptor
> when occurring ADMA error. And it's also used to dump the
> registers whenever calling sdhci_add_host.
>
> On one hand, I don't see any burden to always print the state
> ADMA descriptor as it's rare and will help folks better understand
> what was happening when seeing ADMA error.
>
> On the other, git-blame points out that CONFIG_MMC_DEBUG for
> sdhci_add_host was added since it's merged for the first time.
> I don't know what exactly the intention was, but I guess folks
> don't need it at all? IMHO, it's another all-or-none proposition.
> I'd prefer to remove this sdhci_dumpregs from sdhci_add_host totally.
>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
>
> ---
>
> drivers/mmc/host/sdhci.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ecd0d43..82f1761 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2502,7 +2502,6 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
> sdhci_finish_command(host);
> }
>
> -#ifdef CONFIG_MMC_DEBUG
> static void sdhci_adma_show_error(struct sdhci_host *host)
> {
> void *desc = host->adma_table;
> @@ -2530,9 +2529,6 @@ static void sdhci_adma_show_error(struct sdhci_host *host)
> break;
> }
> }
> -#else
> -static void sdhci_adma_show_error(struct sdhci_host *host) { }
> -#endif
>
> static void sdhci_data_irq(struct sdhci_host *host, u32 intmask)
> {
> @@ -3747,10 +3743,6 @@ int __sdhci_add_host(struct sdhci_host *host)
> goto untasklet;
> }
>
> -#ifdef CONFIG_MMC_DEBUG
> - sdhci_dumpregs(host);
> -#endif
We should still DBG() the interesting registers like SDHCI_HOST_VERSION,
SDHCI_PRESENT_STATE, SDHCI_CAPABILITIES, SDHCI_CAPABILITIES_1. Better to do
it earlier on though, like in sdhci_setup_host() after checking
mmc_regulator_get_supply().
> -
> ret = sdhci_led_register(host);
> if (ret) {
> pr_err("%s: Failed to register LED device: %d\n",
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
