Hi, CONFIG_MMC_DEBUG enables mmc core and driver debugging, and most people should N. I didn't find any point to keep this for core.c as it's just for some WARN or BUG detect. And the debug log around it could be replaced with pr_debug which is easily controlled by system log level, otherwise we should re-compile the kernel and flash zImage agian just for debug. And for some host drivers, it was used to dump registers as well. For the error cases, I think they could directly output the regs, just like what sdhci did. Right? For other cases, for instace, sdhci_add_host uses this macro to dump registers when adding host. I think we just have changed sdhci_dumpregs to use pr_debug and check the log depending on the dynamic log level, so there is no need to still keep it under the context of CONFIG_MMC_DEBUG? I just really don't like compile-time debug option and I didn't ever try to enable it frankly. Is it possible for us to get rid of it? :) -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
