* Will Newton <will.newton@xxxxxxxxx> [170620 05:39]: > Just adding a few people to CC. I'd love to get some feedback as to > whether this patch makes sense or not. > > On Mon, Jun 19, 2017 at 10:36 AM, Will Newton <will.newton@xxxxxxxxx> wrote: > > Reduce max_segs to a value that allows allocation of an entire > > descriptor list within a single page. This avoids doing a > > higher order GFP_ATOMIC allocation when setting up a transfer > > which can potentially fail and lead to I/O failures. I recall we only ever have few SG entries so if there is no performance impact I see no reason to lower it to save memory. Care to check if that's the case still? Regards, Tony > > Signed-off-by: Will Newton <willn@xxxxxxxx> > > --- > > drivers/mmc/host/omap_hsmmc.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > > index 1438a72..d5f42d9 100644 > > --- a/drivers/mmc/host/omap_hsmmc.c > > +++ b/drivers/mmc/host/omap_hsmmc.c > > @@ -2864,9 +2864,9 @@ static int omap_hsmmc_probe(struct platform_device *pdev) > > host->use_adma = true; > > } > > > > - /* Since we do only SG emulation, we can have as many segs > > - * as we want. */ > > - mmc->max_segs = 1024; > > + /* Set this to a value that allows allocating an entire descriptor > > + list within a page (zero order allocation). */ > > + mmc->max_segs = 64; > > > > mmc->max_blk_size = 512; /* Block Length at max can be 1024 */ > > mmc->max_blk_count = 0xFFFF; /* No. of Blocks is 16 bits */ > > -- > > 2.7.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
