On Wed, Jun 14, 2017 at 2:22 PM, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
> Hi Linus,
>
> On 2017/6/14 19:48, Linus Walleij wrote:
>>
>> mmc_blk_ioctl() calls either mmc_blk_ioctl_cmd() or
>> mmc_blk_ioctl_multi_cmd() and each of these make the same
>> check. Factor it into the first call and save one chunk
>> of duplicate code.
>>
>
> Probably you still cannot save the check like what this patch
> does. Refer to commit,
>
> 83c742c344c08 ("mmc: block: fix ABI regression of mmc_blk_ioctl")
AHa I see what's happening. I guess I have to make a small
helper function to check it and inline that instead.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
