On 6/9/2017 5:46 AM, Adrian Hunter wrote:
> On 08/06/17 21:51, Troy Kisky wrote:
>> This lets the loop exit before max_loops reaches 0.
>
> Needs more explanation.
>
>>
>> Fixes: f37b20ebc4bc ("mmc: sdhci: add standard hw auto retuning support")
>>
>> Signed-off-by: Troy Kisky <troy.kisky@xxxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/mmc/host/sdhci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> index ecd0d43..e104194 100644
>> --- a/drivers/mmc/host/sdhci.c
>> +++ b/drivers/mmc/host/sdhci.c
>> @@ -2687,7 +2687,7 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id)
>>
>> /* Clear selected interrupts. */
>> mask = intmask & (SDHCI_INT_CMD_MASK | SDHCI_INT_DATA_MASK |
>> - SDHCI_INT_BUS_POWER);
>> + SDHCI_INT_BUS_POWER | SDHCI_INT_RETUNE);
>
> SDHCI_INT_RETUNE is defined to be read-only so why write to it.
SDHCI_INT_RETUNE is bit 12
host/sdhci.h:#define SDHCI_INT_RETUNE 0x00001000
Which at least from i.mx6/i.mx7 reference manuals, is a write 1 to clear bit(marked as w1c).
>
>> sdhci_writel(host, mask, SDHCI_INT_STATUS);
>>
>> if (intmask & (SDHCI_INT_CARD_INSERT | SDHCI_INT_CARD_REMOVE)) {
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
